On Sat, Oct 27, 2012 at 10:36:24PM +0100, Ian Abbott wrote: > [ Follow upstream commit aaeb61a97b7159ebe30b18a422d04eeabfa8790b ] > > `pc236_detach()` is called by the comedi core if it attempted to attach > a device and failed. `pc236_detach()` calls `pc236_intr_disable()` if > the comedi device private data pointer (`devpriv`) is non-null. This > test is insufficient as `pc236_intr_disable()` accesses hardware > registers and the attach routine may have failed before it has saved > their I/O base addresses. > > Fix it by checking `dev->iobase` is non-zero before calling > `pc236_intr_disable()` as that means the I/O base addresses have been > saved and the hardware registers can be accessed. It also implies the > comedi device private data pointer is valid, so there is no need to > check it. > > Signed-off-by: Ian Abbott <[email protected]> > --- > This patch is for the stable 3.0 kernel.
Applied, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
