This is a note to let you know that I've just added the patch titled
target: Don't return success from module_init() if setup fails
to the 3.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
target-don-t-return-success-from-module_init-if-setup-fails.patch
and it can be found in the queue-3.6 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From 0d0f9dfb31e0a6c92063e235417b42df185b3275 Mon Sep 17 00:00:00 2001
From: Roland Dreier <[email protected]>
Date: Wed, 31 Oct 2012 09:16:44 -0700
Subject: target: Don't return success from module_init() if setup fails
From: Roland Dreier <[email protected]>
commit 0d0f9dfb31e0a6c92063e235417b42df185b3275 upstream.
If the call to core_dev_release_virtual_lun0() fails, then nothing
sets ret to anything other than 0, so even though everything is
torn down and freed, target_core_init_configfs() will seem to succeed
and the module will be loaded. Fix this by passing the return value
on up the chain.
Signed-off-by: Roland Dreier <[email protected]>
Signed-off-by: Nicholas Bellinger <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
drivers/target/target_core_configfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -3214,7 +3214,8 @@ static int __init target_core_init_confi
if (ret < 0)
goto out;
- if (core_dev_setup_virtual_lun0() < 0)
+ ret = core_dev_setup_virtual_lun0();
+ if (ret < 0)
goto out;
return 0;
Patches currently in stable-queue which might be from [email protected] are
queue-3.6/target-avoid-integer-overflow-in-se_dev_align_max_sectors.patch
queue-3.6/target-fix-incorrect-usage-of-nested-irq-spinlocks-in-abort_task-path.patch
queue-3.6/iscsi-target-fix-missed-wakeup-race-in-tx-thread.patch
queue-3.6/target-don-t-return-success-from-module_init-if-setup-fails.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
