On Wed, 2012-11-14 at 15:02 +0100, Peter Senna Tschudin wrote: > Hi Ben, > > On Tue, Nov 13, 2012 at 8:51 PM, Ben Hutchings <[email protected]> wrote: > > On Mon, 2012-11-12 at 00:25 -0500, David Miller wrote: > >> Please queue up the following networking bug fixes for > >> 3.0.x, 3.2.x, 3.4.x, and 3.6.x, respectively. > > [...] > >> From 2204849a85383fbde75680aa199142abe504adbb Mon Sep 17 00:00:00 2001 > >> From: Peter Senna Tschudin <[email protected]> > >> Date: Sun, 28 Oct 2012 06:12:01 +0000 > >> Subject: [PATCH 7/9] drivers/net/phy/mdio-bitbang.c: Call > >> mdiobus_unregister > >> before mdiobus_free > >> > >> [ Upstream commit aa731872f7d33dcb8b54dad0cfb82d4e4d195d7e ] > >> > >> Based on commit b27393aecf66199f5ddad37c302d3e0cfadbe6c0 > >> > >> Calling mdiobus_free without calling mdiobus_unregister causes > >> BUG_ON(). This patch fixes the issue. > > [...] > > > > This introduces a regresssion, as mdiobus_unregister() is not safe to > > call if the bus isn't registered. Registration is controlled by the > > drivers that use mdio-bitbang, and they should take care of > > unregistration too - and most of them do. > > Is mdiobus_free() safe to call if the bus isn't registered? [...]
It must be, otherwise what do you do if mdiobus_register() fails? Ben. -- Ben Hutchings friends: People who know you well, but like you anyway.
signature.asc
Description: This is a digitally signed message part
