This is a note to let you know that I've just added the patch titled
ext4: remove erroneous ext4_superblock_csum_set() in update_backups()
to the 3.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ext4-remove-erroneous-ext4_superblock_csum_set-in-update_backups.patch
and it can be found in the queue-3.6 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From bef53b01faeb791e27605cba1a71ba21364cb23e Mon Sep 17 00:00:00 2001
From: Tao Ma <[email protected]>
Date: Thu, 20 Sep 2012 11:35:38 -0400
Subject: ext4: remove erroneous ext4_superblock_csum_set() in update_backups()
From: Tao Ma <[email protected]>
commit bef53b01faeb791e27605cba1a71ba21364cb23e upstream.
The update_backups() function is used to backup all the metadata
blocks, so we should not take it for granted that 'data' is pointed to
a super block and use ext4_superblock_csum_set to calculate the
checksum there. In case where the data is a group descriptor block,
it will corrupt the last group descriptor, and then e2fsck will
complain about it it.
As all the metadata checksums should already be OK when we do the
backup, remove the wrong ext4_superblock_csum_set and it should be
just fine.
Reported-by: "Theodore Ts'o" <[email protected]>
Signed-off-by: Tao Ma <[email protected]>
Signed-off-by: "Theodore Ts'o" <[email protected]>
Cc: Ben Hutchings <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
fs/ext4/resize.c | 2 --
1 file changed, 2 deletions(-)
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -979,8 +979,6 @@ static void update_backups(struct super_
goto exit_err;
}
- ext4_superblock_csum_set(sb);
-
while ((group = ext4_list_backups(sb, &three, &five, &seven)) < last) {
struct buffer_head *bh;
Patches currently in stable-queue which might be from [email protected] are
queue-3.6/ext4-remove-erroneous-ext4_superblock_csum_set-in-update_backups.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
