On 12/10/2012 07:53 AM, Rafał Miłecki wrote:
> We were using wrong IRQ number so clearing wasn't working at all.
> Depending on a platform this could result in a one device having two
> interrupts assigned. On BCM4706 this resulted in all IRQs being broken.
> 
> Cc: Hauke Mehrtens <[email protected]>
> Cc: [email protected]
> Signed-off-by: Rafał Miłecki <[email protected]>

Acked-by: Hauke Mehrtens <[email protected]>

> ---
> John: I guess it's too late for 3.7 fixes, so I just hope it'll hit
>       3.7.x (and olders) via stable.
> ---
>  drivers/bcma/driver_mips.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/bcma/driver_mips.c b/drivers/bcma/driver_mips.c
> index c45ded8..792daad 100644
> --- a/drivers/bcma/driver_mips.c
> +++ b/drivers/bcma/driver_mips.c
> @@ -115,7 +115,7 @@ static void bcma_core_mips_set_irq(struct bcma_device 
> *dev, unsigned int irq)
>                           bcma_read32(mdev, BCMA_MIPS_MIPS74K_INTMASK(0)) &
>                           ~(1 << irqflag));
>       else
> -             bcma_write32(mdev, BCMA_MIPS_MIPS74K_INTMASK(irq), 0);
> +             bcma_write32(mdev, BCMA_MIPS_MIPS74K_INTMASK(oldirq), 0);
>  
>       /* assign the new one */
>       if (irq == 0) {
> 

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to