From: Andrew Morton <[email protected]> Subject: revert "rtc: recycle id when unloading a rtc driver"
Revert commit 2830a6d20139df2198d63235df7957712adb28e5 Author: Vincent Palatin <[email protected]> Date: Thu Oct 4 17:13:52 2012 -0700 rtc: recycle id when unloading a rtc driver We already perform the ida_simple_remove() in rtc_device_release(), which is an appropriate place. 2830a6d20 ("rtc: recycle id when unloading a rtc driver") caused the kernel to emit ida_remove called for id=0 which is not allocated. warnings when rtc_device_release() tries to release an alread-released ID. Let's restore things to their previous state and then work out why Vincent's kernel wasn't calling rtc_device_release() - presumably a bug in a specific sub-driver. Reported-by: Lothar Waßmann <[email protected]> Acked-by: Alexander Holler <[email protected]> Cc: Vincent Palatin <[email protected]> Cc: <[email protected]> [3.7.x] Signed-off-by: Andrew Morton <[email protected]> --- drivers/rtc/class.c | 1 - 1 file changed, 1 deletion(-) diff -puN drivers/rtc/class.c~revert-rtc-recycle-id-when-unloading-a-rtc-driver drivers/rtc/class.c --- a/drivers/rtc/class.c~revert-rtc-recycle-id-when-unloading-a-rtc-driver +++ a/drivers/rtc/class.c @@ -244,7 +244,6 @@ void rtc_device_unregister(struct rtc_de rtc_proc_del_device(rtc); device_unregister(&rtc->dev); rtc->ops = NULL; - ida_simple_remove(&rtc_ida, rtc->id); mutex_unlock(&rtc->ops_lock); put_device(&rtc->dev); } _ -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
