On Dec 29, 2012, at 6:50 PM, Ben Hutchings <[email protected]> wrote:
> On Sat, 2012-12-29 at 13:10 +0000, Malcolm Priestley wrote: >> shorted back-ported version of upstream commit >> 11d404cb56ecd53bb23499897fbe7be1a9ac4827 >> staging: vt6656: fix headers and add cfg80211. >> key.c only >> >> This patch fixes the deadlock of 64 bit systems >> on successful association. >> >> In key.h void pointer pvKeyTable in SKeyItem is out of alignment >> on 64 bit kernel. >> >> The upstream arrangement of headers fixes this. > [...] > > Please explain how. I don't see anything weird about key.h and mac.h > that would cause structure definitions to be interpreted differently > depending on inclusion order. Also, I would argue that such a dependency is a bug in itself. If such a dependency does exist, it needs to be either resolved so it's not possible for this to happen as described, or it needs a compile-time check to error out if the includes are not done in the proper order. -- Servergy : http://www.servergy.com/ SwissDisk : http://www.swissdisk.com/ Ubuntu : http://www.ubuntu.com/ My Blog : http://ben-collins.blogspot.com/ -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
