This is a note to let you know that I've just added the patch titled
revert "rtc: recycle id when unloading a rtc driver"
to the 3.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
revert-rtc-recycle-id-when-unloading-a-rtc-driver.patch
and it can be found in the queue-3.7 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From 5abe257af8b95857b95fa0ba694530b446ae32d8 Mon Sep 17 00:00:00 2001
From: Andrew Morton <[email protected]>
Date: Thu, 20 Dec 2012 15:05:34 -0800
Subject: revert "rtc: recycle id when unloading a rtc driver"
From: Andrew Morton <[email protected]>
commit 5abe257af8b95857b95fa0ba694530b446ae32d8 upstream.
Revert commit 2830a6d20139df2198d63235df7957712adb28e5.
We already perform the ida_simple_remove() in rtc_device_release(),
which is an appropriate place. Commit 2830a6d20 ("rtc: recycle id when
unloading a rtc driver") caused the kernel to emit
ida_remove called for id=0 which is not allocated.
warnings when rtc_device_release() tries to release an alread-released
ID.
Let's restore things to their previous state and then work out why
Vincent's kernel wasn't calling rtc_device_release() - presumably a bug
in a specific sub-driver.
Reported-by: Lothar WaÃmann <[email protected]>
Acked-by: Alexander Holler <[email protected]>
Cc: Vincent Palatin <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
drivers/rtc/class.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/rtc/class.c
+++ b/drivers/rtc/class.c
@@ -244,7 +244,6 @@ void rtc_device_unregister(struct rtc_de
rtc_proc_del_device(rtc);
device_unregister(&rtc->dev);
rtc->ops = NULL;
- ida_simple_remove(&rtc_ida, rtc->id);
mutex_unlock(&rtc->ops_lock);
put_device(&rtc->dev);
}
Patches currently in stable-queue which might be from [email protected]
are
queue-3.7/revert-rtc-recycle-id-when-unloading-a-rtc-driver.patch
queue-3.7/mm-limit-mmu_gather-batching-to-fix-soft-lockups-on-config_preempt.patch
queue-3.7/lib-atomic64-initialize-locks-statically-to-fix-early-users.patch
queue-3.7/mm-fix-calculation-of-dirtyable-memory.patch
queue-3.7/proc-pid-status-show-all-supplementary-groups.patch
queue-3.7/printk-fix-incorrect-length-from-print_time-when-seconds-99999.patch
queue-3.7/cris-fix-i-o-macros.patch
queue-3.7/exec-do-not-leave-bprm-interp-on-stack.patch
queue-3.7/mm-hugetlb-create-hugetlb-cgroup-file-in-hugetlb_init.patch
queue-3.7/drivers-rtc-rtc-vt8500.c-correct-handling-of-cr_24h-bitfield.patch
queue-3.7/pnpacpi-fix-incorrect-test_alpha-test.patch
queue-3.7/mm-fix-pagehead-when-config_pageflags_extended.patch
queue-3.7/drivers-rtc-rtc-vt8500.c-fix-handling-of-data-passed-in-struct-rtc_time.patch
queue-3.7/sgi-xp-handle-non-fatal-traps.patch
queue-3.7/linux-kernel.h-fix-div_round_closest-with-unsigned-divisors.patch
queue-3.7/vfs-d_obtain_alias-needs-to-use-as-default-name.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
