> -----Original Message----- > From: Greg KH [mailto:[email protected]] > Sent: Monday, January 14, 2013 12:50 PM > To: Dave Airlie; Deucher, Alexander > Cc: [email protected] > Subject: Re: Patch Upstream: drm: fix documentation for > drm_crtc_set_mode() > > I fail to see how the patch below meets the stable_kernel_rules.txt > guidelines. Come on, documentation is good and important, but not > needed for older kernel releases.
Well, the existing documentation for those parameters is wrong and confusing, but you're right it's not a critical bug fix. Feel free to drop it. Alex > > thanks, > > greg k-h > > > On Mon, Dec 17, 2012 at 12:00:56PM -0500, Gregs git-bot wrote: > > commit: 4c9287c6009b37754c42e0ba73a4cc79de92d8f8 > > From: Alex Deucher <[email protected]> > > Date: Fri, 9 Nov 2012 17:26:32 +0000 > > Subject: drm: fix documentation for drm_crtc_set_mode() > > > > x and y parameters are offsets, not width/height > > > > Signed-off-by: Alex Deucher <[email protected]> > > Cc: [email protected] > > Signed-off-by: Dave Airlie <[email protected]> > > --- > > drivers/gpu/drm/drm_crtc_helper.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c > b/drivers/gpu/drm/drm_crtc_helper.c > > index 7105168..b04cf53 100644 > > --- a/drivers/gpu/drm/drm_crtc_helper.c > > +++ b/drivers/gpu/drm/drm_crtc_helper.c > > @@ -346,8 +346,8 @@ drm_crtc_prepare_encoders(struct drm_device > *dev) > > * drm_crtc_set_mode - set a mode > > * @crtc: CRTC to program > > * @mode: mode to use > > - * @x: width of mode > > - * @y: height of mode > > + * @x: horizontal offset into the surface > > + * @y: vertical offset into the surface > > * > > * LOCKING: > > * Caller must hold mode config lock. > > -- > > 1.7.3.4 -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
