On Tue, Jan 15, 2013 at 10:42:46PM -0500, CAI Qian wrote: > Hello Ted, > > This back-port patch is adjusted the context to apply for the 3.0.x, > 3.4.x and 3.7.x stable. Please help ACK/NAK it if possible. > > Regards, > CAI Qian > > From 66bea92c69477a75a5d37b9bfed5773c92a3c4b4 Mon Sep 17 00:00:00 2001 > From: Eric Sandeen <[email protected]> > Date: Wed, 14 Nov 2012 22:22:05 -0500 > Subject: [PATCH] ext4: init pagevec in ext4_da_block_invalidatepages > > ext4_da_block_invalidatepages is missing a pagevec_init(), > which means that pvec->cold contains random garbage. > > This affects whether the page goes to the front or > back of the LRU when ->cold makes it to > free_hot_cold_page() > Looks Good to me:
Reviewed-by: Carlos Maiolino <[email protected]> > Reviewed-by: Lukas Czerner <[email protected]> > Reviewed-by: Carlos Maiolino <[email protected]> > Signed-off-by: Eric Sandeen <[email protected]> > Signed-off-by: "Theodore Ts'o" <[email protected]> > Cc: [email protected] > Signed-off-by: CAI Qian <[email protected]> > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index b3c243b..f89c0e5 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -1503,6 +1503,8 @@ static void ext4_da_block_invalidatepages(struct > mpage_da_data *mpd) > > index = mpd->first_page; > end = mpd->next_page - 1; > + > + pagevec_init(&pvec, 0); > while (index <= end) { > nr_pages = pagevec_lookup(&pvec, mapping, index, PAGEVEC_SIZE); > if (nr_pages == 0) -- Carlos -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
