Hi Romain,
On Wed, Jan 23, 2013 at 11:58:36AM +0100, Romain Francoise wrote:
> Before v2.6.38 CONFIG_EXPERT was known as CONFIG_EMBEDDED but the
> Kconfig entry was not changed to match when upstream commit
> 628c6246d47b85f5357298601df2444d7f4dd3fd ("x86, random: Architectural
> inlines to get random integers with RDRAND") was backported.
>
> Signed-off-by: Romain Francoise <[email protected]>
> ---
> arch/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index aa889d6..ee0168d 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1430,7 +1430,7 @@ config ARCH_USES_PG_UNCACHED
>
> config ARCH_RANDOM
> def_bool y
> - prompt "x86 architectural random number generator" if EXPERT
> + prompt "x86 architectural random number generator" if EMBEDDED
> ---help---
> Enable the x86 architectural RDRAND instruction
> (Intel Bull Mountain technology) to generate random numbers.
So that means that we have never built RDRAND on 2.6.32/2.6.34 yet then !
Sorry for not detecting this :-/
Can you confirm that consecutive to your fix above RDRAND does indeed
work on 2.6.32 ? While I'm sure that the rest of the random stuff was
cleanly tested when Peter provided us with version-specific backports,
I remember that we then picked some architectural changes that Tytso
did for mainline and which were not version-specific. RDRAND was one
of them. I don't know if we messed other things up during this long
backport series. At least it's the only config option which relies on
CONFIG_EXPERT both in 2.6.32 and 2.6.34.
I'm queuing your fix, thank you for that, Romain ! Paul you'll need
it too.
Regards,
Willy
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
