This is a note to let you know that I've just added the patch titled

    module: fix missing module_mutex unlock

to the 3.7-stable tree which can be found at:
    
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     module-fix-missing-module_mutex-unlock.patch
and it can be found in the queue-3.7 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.


>From ee61abb3223e28a1a14a8429c0319755d20d3e40 Mon Sep 17 00:00:00 2001
From: Linus Torvalds <[email protected]>
Date: Sun, 20 Jan 2013 20:22:58 -0800
Subject: module: fix missing module_mutex unlock

From: Linus Torvalds <[email protected]>

commit ee61abb3223e28a1a14a8429c0319755d20d3e40 upstream.

Commit 1fb9341ac348 ("module: put modules in list much earlier") moved
some of the module initialization code around, and in the process
changed the exit paths too.  But for the duplicate export symbol error
case the change made the ddebug_cleanup path jump to after the module
mutex unlock, even though it happens with the mutex held.

Rusty has some patches to split this function up into some helper
functions, hopefully the mess of complex goto targets will go away
eventually.

Reported-by: Dan Carpenter <[email protected]>
Cc: Rusty Russell <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
 kernel/module.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/kernel/module.c
+++ b/kernel/module.c
@@ -3100,8 +3100,8 @@ again:
        /* module_bug_cleanup needs module_mutex protection */
        mutex_lock(&module_mutex);
        module_bug_cleanup(mod);
-       mutex_unlock(&module_mutex);
  ddebug_cleanup:
+       mutex_unlock(&module_mutex);
        dynamic_debug_remove(info.debug);
        synchronize_sched();
        kfree(mod->args);


Patches currently in stable-queue which might be from 
[email protected] are

queue-3.7/drivers-firmware-dmi_scan.c-fetch-dmi-version-from-smbios-if-it-exists.patch
queue-3.7/perf-x86-revert-20b279-require-exclude_guest-to-use-pebs-kernel-side.patch
queue-3.7/ptrace-introduce-signal_wake_up_state-and-ptrace_signal_wake_up.patch
queue-3.7/ptrace-ensure-arch_ptrace-ptrace_request-can-never-race-with-sigkill.patch
queue-3.7/async-fix-__lowest_in_progress.patch
queue-3.7/drivers-firmware-dmi_scan.c-check-dmi-version-when-get.patch
queue-3.7/wake_up_process-should-be-never-used-to-wakeup-a-task_stopped-traced-task.patch
queue-3.7/module-fix-missing-module_mutex-unlock.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to