On Thu, 2013-01-24 at 13:55 -0800, Greg KH wrote: > On Thu, Jan 24, 2013 at 01:43:49PM -0800, Nicholas A. Bellinger wrote: > > On Thu, 2013-01-24 at 10:40 -0800, Greg KH wrote: > > > On Wed, Jan 23, 2013 at 07:16:31PM -0800, Nicholas A. Bellinger wrote: > > > > Hi Greg, > > > > > > > > Please apply this patch to v3.7.y ASAP to address a regression bugfix > > > > introduced with: > > > > > > > > commit fdf9d862969f1be18814273b03fb9497ec2dbdae > > > > Author: Nicholas Bellinger <[email protected]> > > > > Date: Tue Dec 4 23:43:57 2012 -0800 > > > > > > > > target: Add link_magic for fabric allow_link destination > > > > target_items > > > > > > > > Thanks and apologies for the extra work here. > > > > > > > > --nab > > > > > > > > ---------------------------------------------------------------------- > > > > > > > > >From a2faf6488d13aa7f0dabe4ad9b003595b343e42e Mon Sep 17 00:00:00 2001 > > > > From: Nicholas Bellinger <[email protected]> > > > > Date: Wed, 23 Jan 2013 12:17:00 -0800 > > > > Subject: [PATCH] target: Fix v3.7.y stable regression with > > > > dev_link_magic in target_fabric_port_link > > > > > > > > This patch fixes a bug introduced with v3.7.y stable where the > > > > dev->dev_link_magic check was incorrectly positioned head of the *dev > > > > assignment in target_fabric_port_link() > > > > > > > > Reported-by: Chris Boot <[email protected]> > > > > Signed-off-by: Nicholas Bellinger <[email protected]> > > > > --- > > > > drivers/target/target_core_fabric_configfs.c | 11 +++++------ > > > > 1 files changed, 5 insertions(+), 6 deletions(-) > > > > > > What is the git commit id of this patch in Linus's tree? > > > > > > > This regression bug does not effect Linus's tree, only the two stable > > 3.7.y + 3.4.y trees. > > Why? What happened in the stable trees that is so odd? What did I > accept in a different form than was in Linus's tree? >
This was due to hch's removal of struct se_subsystem_dev (reference below), which ended up putting the assignment of struct se_device *dev higher up the callchain within target_fabric_port_link for v3.8-rc1 code. http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=0fd97ccf45be26fb01b3a412f1f6c6b5044b2f16;hp=3d70f8c617a436c7146ecb81df2265b4626dfe89#patch6 Again, my apologies for the extra churn. --nab -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
