On Fri, Jan 25, 2013 at 10:37:14AM +0100, Arend van Spriel wrote: > On 01/25/2013 07:56 AM, CAI Qian wrote: > > OK, will do. > > > > Hello John, Seth etc, > > > > Could you please help ACK/NAK for those two commits to be included > > into the stable? > > Hi CAI Qian, > > These two patches were part of a series of 24 (if I remember correctly). > Just taking these two patches will not suffice. Seth may want to confirm > this, but I think you should take the following:
Yeah, I'd be surprised if the two patches originally requested make much of a difference in isolation. They make only a small change to the amount of buffering brcmsmac is doing internally. Importantly, they do not include the flow control support, and that's the most important part of that patch series. Looking at the Fedora bugzilla, I also note that no one seems to have confirmed that integrating only those two patches improves things at all. > ef2c0512bbf43440a78a6471059e19641eab1e83 > b05618deb4ac7c22d876acc19debb7ac63786f37 > e041f65d5f00011049c7d6af0e31ce69ce9e2655 > 32d0f12a1611421abf70ff7c30d76c739aafad64 > 7f2de08fc0b997ef580a2204e6d14c3c889282c4 > 05f8a6160491ea46636370fbacb4061c341d5d94 > 5c8067caeecbabf8c60dbb73dd517d2a2aad16a5 > ef2c0512bbf43440a78a6471059e19641eab1e83 That's almost right. ef2c051 appears twice; the topmost one should be replaced with 75be3e24eeedbc9ec5faf3483fe9b449abec94e8, and they would need to be applied in reverse of the order given here. The rest of the patches from that series are all related to tracing and debugging. Also skimming the commits it strikes me that c4dea35 (brcmsmac: handle packet drop during transmit correctly) is a good stable candidate, though without the above patches it will require some backporting. I had thought this series was rather too large for stable, 629 insertions and 857 deletions according to git. The sheer volume of changes does make me a bit nervous, although I haven't heard any regressions from these patches in 3.8, and several people have told me that their wireless was essentially useless without them. If Greg doesn't reject them out of hand based on the size, it still might be a good idea to let them bake for a while longer, say maybe until 3.8 final is out. Seth -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
