This is a note to let you know that I've just added the patch titled
usb: dwc3: gadget: change HIRD threshold to 12
to the 3.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-dwc3-gadget-change-hird-threshold-to-12.patch
and it can be found in the queue-3.8 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From 1a947746dbe1486d0e305ab512ddf085b7874cb3 Mon Sep 17 00:00:00 2001
From: Felipe Balbi <[email protected]>
Date: Thu, 24 Jan 2013 11:56:11 +0200
Subject: usb: dwc3: gadget: change HIRD threshold to 12
From: Felipe Balbi <[email protected]>
commit 1a947746dbe1486d0e305ab512ddf085b7874cb3 upstream.
First of all, that 28 value makes no sense as
HIRD threshold is a 4-bit value, second of all
it's causing issues for OMAP5.
Using 12 because commit cbc725b3 (usb: dwc3:
keep default hird threshold value as 4b1100)
had the intention of setting the maximum allowed
value of 0xc.
Also, original code has been wrong forever, so
this should be backported as far back as
possible.
Signed-off-by: Felipe Balbi <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
drivers/usb/dwc3/gadget.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -2190,8 +2190,11 @@ static void dwc3_gadget_conndone_interru
reg = dwc3_readl(dwc->regs, DWC3_DCTL);
reg &= ~(DWC3_DCTL_HIRD_THRES_MASK | DWC3_DCTL_L1_HIBER_EN);
- /* TODO: This should be configurable */
- reg |= DWC3_DCTL_HIRD_THRES(28);
+ /*
+ * TODO: This should be configurable. For now using
+ * maximum allowed HIRD threshold value of 0b1100
+ */
+ reg |= DWC3_DCTL_HIRD_THRES(12);
dwc3_writel(dwc->regs, DWC3_DCTL, reg);
}
Patches currently in stable-queue which might be from [email protected] are
queue-3.8/usb-dwc3-gadget-change-hird-threshold-to-12.patch
queue-3.8/usb-dwc3-gadget-fix-missed-isoc.patch
queue-3.8/usb-dwc3-enable-usb2-lpm-only-when-connected-as-usb2.0.patch
queue-3.8/usb-dwc3-gadget-fix-isoc-end-transfer-condition.patch
queue-3.8/usb-dwc3-gadget-fix-skip-link_trb-on-isoc.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
