This is a note to let you know that I've just added the patch titled
USB: quatech2: fix use-after-free in TIOCMIWAIT
to the 3.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-quatech2-fix-use-after-free-in-tiocmiwait.patch
and it can be found in the queue-3.8 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From 69f87f40d2b98e8b4ab82a121fd2bd584690b887 Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Tue, 19 Mar 2013 09:21:23 +0100
Subject: USB: quatech2: fix use-after-free in TIOCMIWAIT
From: Johan Hovold <[email protected]>
commit 69f87f40d2b98e8b4ab82a121fd2bd584690b887 upstream.
Use the port wait queue and make sure to check the serial disconnected
flag before accessing private port data after waking up.
This is is needed as the private port data (including the wait queue
itself) can be gone when waking up after a disconnect.
Signed-off-by: Johan Hovold <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
drivers/usb/serial/quatech2.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
--- a/drivers/usb/serial/quatech2.c
+++ b/drivers/usb/serial/quatech2.c
@@ -128,7 +128,6 @@ struct qt2_port_private {
u8 shadowLSR;
u8 shadowMSR;
- wait_queue_head_t delta_msr_wait; /* Used for TIOCMIWAIT */
struct async_icount icount;
struct usb_serial_port *port;
@@ -506,8 +505,9 @@ static int wait_modem_info(struct usb_se
spin_unlock_irqrestore(&priv->lock, flags);
while (1) {
- wait_event_interruptible(priv->delta_msr_wait,
- ((priv->icount.rng != prev.rng) ||
+ wait_event_interruptible(port->delta_msr_wait,
+ (port->serial->disconnected ||
+ (priv->icount.rng != prev.rng) ||
(priv->icount.dsr != prev.dsr) ||
(priv->icount.dcd != prev.dcd) ||
(priv->icount.cts != prev.cts)));
@@ -515,6 +515,9 @@ static int wait_modem_info(struct usb_se
if (signal_pending(current))
return -ERESTARTSYS;
+ if (port->serial->disconnected)
+ return -EIO;
+
spin_lock_irqsave(&priv->lock, flags);
cur = priv->icount;
spin_unlock_irqrestore(&priv->lock, flags);
@@ -841,7 +844,6 @@ static int qt2_port_probe(struct usb_ser
spin_lock_init(&port_priv->lock);
spin_lock_init(&port_priv->urb_lock);
- init_waitqueue_head(&port_priv->delta_msr_wait);
port_priv->port = port;
port_priv->write_urb = usb_alloc_urb(0, GFP_KERNEL);
@@ -984,7 +986,7 @@ static void qt2_update_msr(struct usb_se
if (newMSR & UART_MSR_TERI)
port_priv->icount.rng++;
- wake_up_interruptible(&port_priv->delta_msr_wait);
+ wake_up_interruptible(&port->delta_msr_wait);
}
}
Patches currently in stable-queue which might be from [email protected] are
queue-3.8/usb-quatech2-fix-use-after-free-in-tiocmiwait.patch
queue-3.8/usb-ark3116-fix-use-after-free-in-tiocmiwait.patch
queue-3.8/usb-cypress_m8-fix-use-after-free-in-tiocmiwait.patch
queue-3.8/usb-pl2303-fix-use-after-free-in-tiocmiwait.patch
queue-3.8/usb-io_edgeport-fix-use-after-free-in-tiocmiwait.patch
queue-3.8/usb-ch341-fix-use-after-free-in-tiocmiwait.patch
queue-3.8/usb-mos7840-fix-broken-tiocmiwait.patch
queue-3.8/usb-spcp8x5-fix-use-after-free-in-tiocmiwait.patch
queue-3.8/usb-ti_usb_3410_5052-fix-use-after-free-in-tiocmiwait.patch
queue-3.8/usb-serial-fix-hang-when-opening-port.patch
queue-3.8/usb-f81232-fix-use-after-free-in-tiocmiwait.patch
queue-3.8/usb-mct_u232-fix-use-after-free-in-tiocmiwait.patch
queue-3.8/usb-oti6858-fix-use-after-free-in-tiocmiwait.patch
queue-3.8/usb-ftdi_sio-fix-use-after-free-in-tiocmiwait.patch
queue-3.8/usb-serial-add-modem-status-change-wait-queue.patch
queue-3.8/usb-io_ti-fix-use-after-free-in-tiocmiwait.patch
queue-3.8/usb-ssu100-fix-use-after-free-in-tiocmiwait.patch
queue-3.8/usb-mos7840-fix-use-after-free-in-tiocmiwait.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
