Hi Christoph, On Thu, Jun 06, 2013 at 10:33:02PM +0200, Christoph Biedl wrote: > Willy Tarreau wrote... > > > Could you please instead test the following patch which passes asmregparm > > in ptrace.h ? > > Spectacular breakage: > > CC arch/x86/kernel/asm-offsets.s > In file included from <BUILD-DIR>arch/x86/include/asm/vm86.h:130:0, > from <BUILD-DIR>arch/x86/include/asm/processor.h:10, > from <BUILD-DIR>arch/x86/include/asm/atomic_32.h:6, > from <BUILD-DIR>arch/x86/include/asm/atomic.h:2, > from include/linux/crypto.h:20, > from arch/x86/kernel/asm-offsets_32.c:7, > from arch/x86/kernel/asm-offsets.c:2: > <BUILD-DIR>arch/x86/include/asm/ptrace.h:145:19: error: expected ???=???, > ???,???, ???;???, ???asm??? or ???__attribute__??? before ???long??? > <BUILD-DIR>arch/x86/include/asm/ptrace.h:146:19: error: expected ???=???, > ???,???, ???;???, ???asm??? or ???__attribute__??? before ???void??? > make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1 > make: *** [prepare0] Error 2
Hmmm indeed, an include is missing here for asmregparm. Adding the following line fixes the problem for me : --- a/arch/x86/include/asm/ptrace.h +++ b/arch/x86/include/asm/ptrace.h @@ -2,6 +2,7 @@ #define _ASM_X86_PTRACE_H #include <linux/compiler.h> /* For __user */ +#include <linux/linkage.h> /* For asmregparm */ #include <asm/ptrace-abi.h> #include <asm/processor-flags.h> I'd suggest that if the kernel build goes to the end for you, we merge this as well, otherwise we leave the two changes pending and focus on supporting gcc 4.7 later. Thanks, Willy -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
