On Thu, 2013-07-11 at 16:31 -0700, [email protected] wrote: > The patch below was submitted to be applied to the 3.10-stable tree. > > I fail to see how this patch meets the stable kernel rules as found at > Documentation/stable_kernel_rules.txt. > > I could be totally wrong, and if so, please respond to > <[email protected]> and let me know why this patch should be > applied. Otherwise, it is now dropped from my patch queues, never to be > seen again.
Agreed. I need to push back on some of these rpc_pipefs net namespace race changes anyway: one of them had clearly not been adequately tested prior to submission, and required emergency surgery in a second pull request. Apologies, Trond > thanks, > > greg k-h > > ------------------ original commit in Linus's tree ------------------ > > From 4f6bb246f69443549fbbd0f2abaf863243cb35e9 Mon Sep 17 00:00:00 2001 > From: Stanislav Kinsbursky <[email protected]> > Date: Mon, 24 Jun 2013 11:52:59 +0400 > Subject: [PATCH] SUNRPC: PipeFS MOUNT notification optimization for dying > clients > > Not need to create pipes for dying client. So just skip them. > > Note: we can safely dereference the client structure, because notification > caller is holding sn->pipefs_sb_lock. > > Signed-off-by: Stanislav Kinsbursky <[email protected]> > Cc: [email protected] > Signed-off-by: Trond Myklebust <[email protected]> > > diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c > index b4f17117..f0339ae9 100644 > --- a/net/sunrpc/clnt.c > +++ b/net/sunrpc/clnt.c > @@ -177,6 +177,8 @@ static inline int rpc_clnt_skip_event(struct rpc_clnt > *clnt, unsigned long event > if (((event == RPC_PIPEFS_MOUNT) && clnt->cl_dentry) || > ((event == RPC_PIPEFS_UMOUNT) && !clnt->cl_dentry)) > return 1; > + if ((event == RPC_PIPEFS_MOUNT) && atomic_read(&clnt->cl_count) == 0) > + return 1; > return 0; > } > > -- Trond Myklebust Linux NFS client maintainer NetApp [email protected] www.netapp.com N�����r��y����b�X��ǧv�^�){.n�+������z)����w*jg��������ݢj/���z�ޖ��2�ޙ����&�)ߡ�a�����G���h��j:+v���w��٥
