On Sat, Jul 27, 2013 at 08:41:12AM -0700, Greg KH wrote:
> On Sat, Jul 27, 2013 at 08:09:29AM -0700, Greg KH wrote:
> > On Sat, Jul 27, 2013 at 01:34:42PM +0200, Johan Hovold wrote:
> > > Silence compiler warnings on 64-bit systems introduced by commit
> > > 05cf0dec ("USB: mos7840: fix race in led handling") which uses the
> > > usb-serial data pointer to temporarily store the device type during
> > > probe but failed to add the required casts.
> > >
> > > Cc: [email protected]
> > > Signed-off-by: Johan Hovold <[email protected]>
> > > ---
> > > drivers/usb/serial/mos7840.c | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> > > index c10fc15..6350628 100644
> > > --- a/drivers/usb/serial/mos7840.c
> > > +++ b/drivers/usb/serial/mos7840.c
> > > @@ -2221,14 +2221,14 @@ static int mos7840_probe(struct usb_serial
> > > *serial,
> > >
> > > kfree(buf);
> > > out:
> > > - usb_set_serial_data(serial, (void *)device_type);
> > > + usb_set_serial_data(serial, (void *)(uintptr_t)device_type);
> >
> > Really? uintptr_t isn't a "normal" kernel type.
>
> As Linux requires that an unsigned long fit into a pointer, you can
> change these to be "unsigned long" and that fixes the warning. Want me
> to change that up in the patch?
Yes, please do that if you prefer not to use the typedef.
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
