From 43b3fcb3e58b6d10b70c08f5b2259a64a195f1a5 Mon Sep 17 00:00:00 2001 From: Amitkumar Karwar Date: Wed, 25 Sep 2013 21:21:29 +0530 Subject: [PATCH] mwifiex: avoid redundant main process queueing As we use single threaded workqueue, the only possiblity for concurrent mwifiex_main_process() calls is during SDIO interrupts where the routine is directly called. Recently queue_work() call is added to fix corner case SDIO interrupt lost issue. With this change main process is sometimes unnecessarily queued multiple times which results in increased CPU utilization. This patch makes sure that currently running main process will always take care of pending interrupts. We don't need to queue an extra main process. This fixes interrupt lost issue. Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/mwifiex/main.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/mwifiex/main.c b/drivers/net/wireless/mwifiex/main.c index 516b80e..dd6548e 100644 --- a/drivers/net/wireless/mwifiex/main.c +++ b/drivers/net/wireless/mwifiex/main.c @@ -235,7 +235,6 @@ int mwifiex_main_process(struct mwifiex_adapter *adapter) /* Check if already processing */ if (adapter->mwifiex_processing) { spin_unlock_irqrestore(&adapter->main_proc_lock, flags); - queue_work(adapter->workqueue, &adapter->main_work); goto exit_main_proc; } else { adapter->mwifiex_processing = true; @@ -359,10 +358,12 @@ process_start: } } while (true); - if ((adapter->int_status) || IS_CARD_RX_RCVD(adapter)) + spin_lock_irqsave(&adapter->main_proc_lock, flags); + if ((adapter->int_status) || IS_CARD_RX_RCVD(adapter)) { + spin_unlock_irqrestore(&adapter->main_proc_lock, flags); goto process_start; + } - spin_lock_irqsave(&adapter->main_proc_lock, flags); adapter->mwifiex_processing = false; spin_unlock_irqrestore(&adapter->main_proc_lock, flags); -- 1.7.3.4