Re: [PATCH 2/9] backlight: atmel-pwm-bl: fix gpio polarity in remove

Fri, 25 Oct 2013 05:25:54 -0700 

On 11:55 Wed 23 Oct     , Johan Hovold wrote:
> Make sure to honour gpio polarity also at remove so that the backlight
> is actually disabled on boards with active-low enable pin.
> 
> Cc: [email protected]
> Acked-by: Jingoo Han <[email protected]>
> Signed-off-by: Johan Hovold <[email protected]>
> ---
>  drivers/video/backlight/atmel-pwm-bl.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/backlight/atmel-pwm-bl.c 
> b/drivers/video/backlight/atmel-pwm-bl.c
> index 8aac273..3cb0094 100644
> --- a/drivers/video/backlight/atmel-pwm-bl.c
> +++ b/drivers/video/backlight/atmel-pwm-bl.c
> @@ -205,8 +205,10 @@ static int atmel_pwm_bl_remove(struct platform_device 
> *pdev)
>  {
>       struct atmel_pwm_bl *pwmbl = platform_get_drvdata(pdev);
>  
> -     if (pwmbl->gpio_on != -1)
> -             gpio_set_value(pwmbl->gpio_on, 0);
> +     if (pwmbl->gpio_on != -1) {
here we need to use gpio_is_valid
> +             gpio_set_value(pwmbl->gpio_on,
> +                                     0 ^ pwmbl->pdata->on_active_low);
> +     }
>       pwm_channel_disable(&pwmbl->pwmc);
>       pwm_channel_free(&pwmbl->pwmc);
>  
> -- 
> 1.8.4
> 
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to