On Fri, Nov 08, 2013 at 09:43:35PM -0800, [email protected] wrote: > > The patch below does not apply to the 3.11-stable tree. > If someone wants it applied there, or to any other stable or longterm > tree, then please email the backport, including the original git commit > id to <[email protected]>.
Hi Greg, To apply this patch, you need to apply first 682dfdc0 "clk: armada-370: Fix incorrect placement of __initconst". Is that OK or do you want me to update the patch without the __initconst placement fix ? Moreover you have to know that this patch fixes a typo which have been in fact introduced by 97fa4cf4 "clk: mvebu: add mvebu core clocks" and not by 6b72333d "clk: mvebu: add Armada 370 SoC-centric clock init". 6b72333d only moves the typo from a file to an another... I realize I should have mentioned this original git commit id in my commit message because I'd like to see this typo fixed since introduced (Linux 3.8). This also means that a backport is needed for the stable branches 3.8, 3.9 and 3.10. If you agree I will provide this backport. Thanks, Simon > > thanks, > > greg k-h > > ------------------ original commit in Linus's tree ------------------ > > >From 1022c75f5abd3a3b25e679bc8793d21bedd009b4 Mon Sep 17 00:00:00 2001 > From: Simon Guinot <[email protected]> > Date: Thu, 3 Oct 2013 12:05:02 +0200 > Subject: [PATCH] clk: armada-370: fix tclk frequencies > > This patch fixes the tclk frequency array for the Armada-370 SoC. > This bug has been introduced by commit 6b72333d > ("clk: mvebu: add Armada 370 SoC-centric clock init"). > > A wrong tclk frequency affects the following drivers: mvsdio, mvneta, > i2c-mv64xxx and mvebu-devbus. This list may be incomplete. > > About the mvneta Ethernet driver, note that the tclk frequency is used > to compute the Rx time coalescence. Then, this bug harms the coalescence > configuration and also degrades the networking performances with the > default values. > > Signed-off-by: Simon Guinot <[email protected]> > Cc: Andrew Lunn <[email protected]> > Cc: Gregory CLEMENT <[email protected]> > Cc: Sebastian Hesselbarth <[email protected]> > Acked-by: Jason Cooper <[email protected]> > Cc: [email protected] > Signed-off-by: Michael Turquette <[email protected]> > > diff --git a/drivers/clk/mvebu/armada-370.c b/drivers/clk/mvebu/armada-370.c > index fc777bdc1886..81a202d12a7a 100644 > --- a/drivers/clk/mvebu/armada-370.c > +++ b/drivers/clk/mvebu/armada-370.c > @@ -39,8 +39,8 @@ static const struct coreclk_ratio a370_coreclk_ratios[] > __initconst = { > }; > > static const u32 a370_tclk_freqs[] __initconst = { > - 16600000, > - 20000000, > + 166000000, > + 200000000, > }; > > static u32 __init a370_get_tclk_freq(void __iomem *sar)
signature.asc
Description: Digital signature
