On Wed, Nov 27, 2013 at 1:13 PM, Russell King - ARM Linux <[email protected]> wrote: > On Wed, Nov 27, 2013 at 12:51:39PM +0100, Linus Walleij wrote: >> This is because the macro operations in smc91x.h are missing >> necessary #defines for operations such as SMC_inbsw(), >> SMC_outsw() and SMC_outsb() making these defined to BUG(). >> >> The Versatile needs and uses the same accessors as the other >> platforms in the first if(...) clause, just switch it to using >> that and we have one problem less to worry about. >> >> This bug seems to have been around for some quite time, just >> that few people test the Versatile on real hardware, and it >> compiles. > > That's a misconception. This bug is caused by: > > commit e9e4ea74f06635f2ffc1dffe5ef40c854faa0a90 > Author: Will Deacon <[email protected]> > Date: Fri Oct 11 14:52:20 2013 +0100 > > net: smc91x: dont't use SMC_outw for fixing up halfword-aligned data
Ah, you're right, reverting that makes things work. This patch should still be a viable solution, I'll fix up the commit message and repost a v2. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
