This is a note to let you know that I've just added the patch titled
cpupower: Fix segfault due to incorrect getopt_long arugments
to the 3.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
cpupower-fix-segfault-due-to-incorrect-getopt_long-arugments.patch
and it can be found in the queue-3.12 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From f447ef4a56dee4b68a91460bcdfe06b5011085f2 Mon Sep 17 00:00:00 2001
From: Josh Boyer <[email protected]>
Date: Fri, 11 Oct 2013 08:45:51 -0400
Subject: cpupower: Fix segfault due to incorrect getopt_long arugments
From: Josh Boyer <[email protected]>
commit f447ef4a56dee4b68a91460bcdfe06b5011085f2 upstream.
If a user calls 'cpupower set --perf-bias 15', the process will end with
a SIGSEGV in libc because cpupower-set passes a NULL optarg to the atoi
call. This is because the getopt_long structure currently has all of
the options as having an optional_argument when they really have a
required argument. We change the structure to use required_argument to
match the short options and it resolves the issue.
This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1000439
Signed-off-by: Josh Boyer <[email protected]>
Cc: Dominik Brodowski <[email protected]>
Cc: Thomas Renninger <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
tools/power/cpupower/utils/cpupower-set.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/tools/power/cpupower/utils/cpupower-set.c
+++ b/tools/power/cpupower/utils/cpupower-set.c
@@ -18,9 +18,9 @@
#include "helpers/bitmask.h"
static struct option set_opts[] = {
- { .name = "perf-bias", .has_arg = optional_argument, .flag = NULL,
.val = 'b'},
- { .name = "sched-mc", .has_arg = optional_argument, .flag = NULL,
.val = 'm'},
- { .name = "sched-smt", .has_arg = optional_argument, .flag = NULL,
.val = 's'},
+ { .name = "perf-bias", .has_arg = required_argument, .flag = NULL,
.val = 'b'},
+ { .name = "sched-mc", .has_arg = required_argument, .flag = NULL,
.val = 'm'},
+ { .name = "sched-smt", .has_arg = required_argument, .flag = NULL,
.val = 's'},
{ },
};
Patches currently in stable-queue which might be from [email protected] are
queue-3.12/cpupower-fix-segfault-due-to-incorrect-getopt_long-arugments.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
