On Mon, Jan 20, 2014 at 08:21:54AM +0100, Daniel Vetter wrote: > At least drm/i915 expects that the obj->dev pointer is set even in > failure paths. Specifically when the shmem initialization fails we > call i915_gem_object_free which needs to deref obj->base.dev to get at > the slab pointer in the device private structure. And the shmem > allocation can easily fail when userspace is hitting open file limits. > > Doing the structure init even when the shmem file allocation fails > prevents this Oops.
Regression from commit 89c8233f82d9c8af5b20e72e4a185a38a7d3c50b Author: David Herrmann <[email protected]> Date: Thu Jul 11 11:56:32 2013 +0200 drm/gem: simplify object initialization > Testcase: igt/gem_fd_exhaustion > Reported-and-Suggested-by: Linus Torvalds <[email protected]> > Cc: Linus Torvalds <[email protected]> > References: > http://lists.freedesktop.org/archives/intel-gfx/2014-January/038433.html > Cc: [email protected] > Signed-off-by: Daniel Vetter <[email protected]> Cc: David Herrmann <[email protected]> -- Chris Wilson, Intel Open Source Technology Centre -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
