From: Pali Rohár <[email protected]> Subject: afs: proc cells and rootcell are writeable
Both proc files are writeable and used for configuring cells. But there is missing correct mode flag for writeable files. Without this patch it is not possible to write to cells and rootcell files which means that it is not possible to add new servers to cells, so it is not possible to access afs disks and afs driver is unusable. Signed-off-by: Pali Rohr <[email protected]> Cc: David Howells <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]> --- fs/afs/proc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff -puN fs/afs/proc.c~afs-proc-cells-and-rootcell-are-writeable fs/afs/proc.c --- a/fs/afs/proc.c~afs-proc-cells-and-rootcell-are-writeable +++ a/fs/afs/proc.c @@ -130,8 +130,10 @@ int afs_proc_init(void) if (!proc_afs) goto error_dir; - if (!proc_create("cells", 0, proc_afs, &afs_proc_cells_fops) || - !proc_create("rootcell", 0, proc_afs, &afs_proc_rootcell_fops)) + if (!proc_create("cells", S_IFREG | S_IRUGO | S_IWUSR, proc_afs, + &afs_proc_cells_fops) || + !proc_create("rootcell", S_IFREG | S_IRUGO | S_IWUSR, proc_afs, + &afs_proc_rootcell_fops)) goto error_tree; _leave(" = 0"); _ -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
