[Sent again, sorry for the HTML mail before.]

--On March 06, 2014 16:57 -0500 David Miller <[email protected]> wrote:

From: Christian Riesch <[email protected]>
Date: Wed, 5 Mar 2014 11:25:28 +0100

@@ -1641,7 +1640,15 @@ static int emac_dev_open(struct net_device *ndev)

 rollback:

-       dev_err(emac_dev, "DaVinci EMAC: devm_request_irq() failed");
+       dev_err(emac_dev, "DaVinci EMAC: request_irq() failed");
+
+       for (q = k; k >= 0; k--) {
+               for (m = i; m >= res->start; m--)
+                       free_irq(m, ndev);
+               res = platform_get_resource(priv->pdev, IORESOURCE_IRQ, k-1);
+               m = res->end;
+       }

This final assignment in the loop of 'm' is unused?

The inner for() loop always started with "m = i;"

This should probably read 

i = res->end; 

I just took the old code without thinking about it. Thanks for catching it.

Christian
 

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to