On Fri, Mar 28, 2014 at 12:33:34PM -0500, Mark Tinguely wrote: > Fix the fix directory "bad hash ordering" bug introduced in > commit f5ea1100. > > Reported-by: Hannes Frederic Sowa <[email protected]> > Signed-off-by: Mark Tinguely <[email protected]> > --- > A C program that generates this problem can be found at: > http://oss.sgi.com/archives/xfs/2014-03/msg00373.html > > A xfstest for this bug is coming from Hannes Frederic Sowa. > > fs/xfs/xfs_da_btree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: b/fs/xfs/xfs_da_btree.c > =================================================================== > --- a/fs/xfs/xfs_da_btree.c > +++ b/fs/xfs/xfs_da_btree.c > @@ -1295,7 +1295,7 @@ xfs_da3_fixhashpath( > node = blk->bp->b_addr; > dp->d_ops->node_hdr_from_disk(&nodehdr, node); > btree = dp->d_ops->node_tree_p(node); > - if (be32_to_cpu(btree->hashval) == lasthash) > + if (be32_to_cpu(btree[blk->index].hashval) == lasthash) > break; > blk->hashval = lasthash; > btree[blk->index].hashval = cpu_to_be32(lasthash);
Looks good to me. Reviewed-by: Ben Myers <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
