On 05/07/2014 10:27 AM, Tomas Novotny wrote: > On Tue, 6 May 2014 11:19:25 +0200 > Jiri Slaby <[email protected]> wrote: > >> From: Tomas Novotny <[email protected]> >> >> This patch does NOT apply to the 3.12 stable tree. If you still want >> it applied, please provide a backport. >> >> =============== >> >> commit 56816b700c8c773270f3aaf4c92be53e359a03fd upstream. >> >> There are some unused registers in twl4030 at I2C address 0x49 and function >> twl4030_49_nop_reg() is used to check accessibility of that registers. These >> registers are written in decimal format but the values are correct in >> hexadecimal format. (It can be checked few lines above the patched code - >> these registers are marked as unused there.) >> >> As a consequence three registers of audio submodule are treated as >> inaccessible (preamplifier carkit right and both handsfree registers). >> >> Cc: [email protected] >> Signed-off-by: Tomas Novotny <[email protected]> >> Signed-off-by: Lee Jones <[email protected]> >> --- >> drivers/mfd/twl-core.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c >> index ed718328eff1..e87140bef667 100644 >> --- a/drivers/mfd/twl-core.c >> +++ b/drivers/mfd/twl-core.c >> @@ -282,11 +282,11 @@ static struct reg_default twl4030_49_defaults[] = { >> static bool twl4030_49_nop_reg(struct device *dev, unsigned int reg) >> { >> switch (reg) { >> - case 0: >> - case 3: >> - case 40: >> - case 41: >> - case 42: >> + case 0x00: >> + case 0x03: >> + case 0x40: >> + case 0x41: >> + case 0x42: >> return false; >> default: >> return true; > > Hi, > > that fix is needed in 3.14 only, no need to backport to 3.12.
Ok, thanks. -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
