This is a note to let you know that I've just added the patch titled

    batman-adv: fix indirect hard_iface NULL dereference

to the 3.14-stable tree which can be found at:
    
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     batman-adv-fix-indirect-hard_iface-null-dereference.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.


>From foo@baz Wed May 28 21:03:54 PDT 2014
From: Marek Lindner <[email protected]>
Date: Thu, 24 Apr 2014 03:44:25 +0800
Subject: batman-adv: fix indirect hard_iface NULL dereference

From: Marek Lindner <[email protected]>

[ Upstream commit 16a4142363b11952d3aa76ac78004502c0c2fe6e ]

If hard_iface is NULL and goto out is made batadv_hardif_free_ref()
doesn't check for NULL before dereferencing it to get to refcount.

Introduced in cb1c92ec37fb70543d133a1fa7d9b54d6f8a1ecd
("batman-adv: add debugfs support to view multiif tables").

Reported-by: Sven Eckelmann <[email protected]>
Signed-off-by: Marek Lindner <[email protected]>
Acked-by: Antonio Quartulli <[email protected]>
Signed-off-by: Antonio Quartulli <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
 net/batman-adv/originator.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/net/batman-adv/originator.c
+++ b/net/batman-adv/originator.c
@@ -1074,7 +1074,8 @@ int batadv_orig_hardif_seq_print_text(st
        bat_priv->bat_algo_ops->bat_orig_print(bat_priv, seq, hard_iface);
 
 out:
-       batadv_hardif_free_ref(hard_iface);
+       if (hard_iface)
+               batadv_hardif_free_ref(hard_iface);
        return 0;
 }
 


Patches currently in stable-queue which might be from 
[email protected] are

queue-3.14/batman-adv-fix-reference-counting-imbalance-while.patch
queue-3.14/batman-adv-fix-neigh-reference-imbalance.patch
queue-3.14/batman-adv-fix-local-tt-check-for-outgoing-arp.patch
queue-3.14/batman-adv-increase-orig-refcount-when-storing-ref-in.patch
queue-3.14/batman-adv-fix-neigh_ifinfo-imbalance.patch
queue-3.14/batman-adv-fix-indirect-hard_iface-null-dereference.patch
queue-3.14/batman-adv-always-run-purge_orig_neighbors.patch
queue-3.14/batman-adv-fix-removing-neigh_ifinfo.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to