----- Original Message ----- > Commit "drm/vmwgfx: correct fb_fix_screeninfo.line_length", while fixing a > vmwgfx fbdev bug, also writes the pitch to a supposedly read-only register: > SVGA_REG_BYTES_PER_LINE, while it should be (and also in fact is) written to > SVGA_REG_PITCHLOCK. > > There has been some reports of incorrect rendering with the mentioned commit > and Ubuntu 12.04. While hard to reproduce, hopefully this patch will correct > that issue. > > Cc: [email protected] > Cc: Christopher Friedt <[email protected]> > Tested-by: Christopher Friedt <[email protected]> > Signed-off-by: Thomas Hellstrom <[email protected]> > --- > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 1 - > 1 file changed, 1 deletion(-)
Reviewed-by: Jakob Bornecrantz <[email protected]> > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c > b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c > index a89ad93..b031b48 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c > @@ -179,7 +179,6 @@ static int vmw_fb_set_par(struct fb_info *info) > vmw_write(vmw_priv, SVGA_REG_DISPLAY_POSITION_Y, > info->var.yoffset); > vmw_write(vmw_priv, SVGA_REG_DISPLAY_WIDTH, info->var.xres); > vmw_write(vmw_priv, SVGA_REG_DISPLAY_HEIGHT, info->var.yres); > - vmw_write(vmw_priv, SVGA_REG_BYTES_PER_LINE, > info->fix.line_length); > vmw_write(vmw_priv, SVGA_REG_DISPLAY_ID, SVGA_ID_INVALID); > } > > -- > 1.8.3.2 > -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
