On Mon, 07 Jul 2014 13:42:37 -0700 <[email protected]> wrote:
> > This is a note to let you know that I've just added the patch titled > > md: make sure GET_ARRAY_INFO ioctl reports correct "clean" status > > to the 3.4-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > md-make-sure-get_array_info-ioctl-reports-correct-clean-status.patch > and it can be found in the queue-3.4 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let <[email protected]> know about it. I wasn't expecting this patch to enter the stable tree as I didn't add "cc: stable". I guess your scripts picked up on the "Fixes:" tag? Just because a patch "fixes" a bug, that doesn't mean that it meets the requirements of "-stable". I would really like to be able to record these connections without them triggering a backport. Should I use "Fixes-but-not-needed-for-stable"?? In this case I don't object to the patch going to -stable as it really is very very trivial. But the bug itself is trivial and doesn't justify a -stable update. Can we have one-tag-one-meaning please? Thanks, NeilBrown > > > >From 9bd359203210efeb5d8f0d81c155079f34b47449 Mon Sep 17 00:00:00 2001 > From: NeilBrown <[email protected]> > Date: Wed, 2 Jul 2014 11:35:06 +1000 > Subject: md: make sure GET_ARRAY_INFO ioctl reports correct "clean" status > > From: NeilBrown <[email protected]> > > commit 9bd359203210efeb5d8f0d81c155079f34b47449 upstream. > > If an array has a bitmap, the when we set the "has bitmap" flag we > incorrectly clear the "is clean" flag. > > "is clean" isn't really important when a bitmap is present, but it is > best to get it right anyway. > > Reported-by: George Duffield <[email protected]> > Link: > http://lkml.kernel.org/cag__1a4mrv6gjl38xlaurtosid3rlbtmwpcs5hyvppsfpr8...@mail.gmail.com > Fixes: 36fa30636fb84b209210299684e1be66d9e58217 (v2.6.14) > Signed-off-by: NeilBrown <[email protected]> > Signed-off-by: Greg Kroah-Hartman <[email protected]> > > --- > drivers/md/md.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/md/md.c > +++ b/drivers/md/md.c > @@ -5409,7 +5409,7 @@ static int get_array_info(struct mddev * > if (mddev->in_sync) > info.state = (1<<MD_SB_CLEAN); > if (mddev->bitmap && mddev->bitmap_info.offset) > - info.state = (1<<MD_SB_BITMAP_PRESENT); > + info.state |= (1<<MD_SB_BITMAP_PRESENT); > info.active_disks = insync; > info.working_disks = working; > info.failed_disks = failed; > > > Patches currently in stable-queue which might be from [email protected] are > > queue-3.4/md-make-sure-get_array_info-ioctl-reports-correct-clean-status.patch > queue-3.4/md-flush-writes-before-starting-a-recovery.patch
signature.asc
Description: PGP signature
