From: Sasha Levin <[email protected]> Subject: kernel/smp.c:on_each_cpu_cond(): fix warning in fallback path
The rarely-executed memry-allocation-failed callback path generates a WARN_ON_ONCE() when smp_call_function_single() succeeds. Presumably it's supposed to warn on failures. Signed-off-by: Sasha Levin <[email protected]> Cc: Christoph Lameter <[email protected]> Cc: Gilad Ben-Yossef <[email protected]> Cc: David Rientjes <[email protected]> Cc: Joonsoo Kim <[email protected]> Cc: Tejun Heo <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]> --- kernel/smp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN kernel/smp.c~kernel-smpc-on_each_cpu_cond-fix-warning-in-fallback-path kernel/smp.c --- a/kernel/smp.c~kernel-smpc-on_each_cpu_cond-fix-warning-in-fallback-path +++ a/kernel/smp.c @@ -670,7 +670,7 @@ void on_each_cpu_cond(bool (*cond_func)( if (cond_func(cpu, info)) { ret = smp_call_function_single(cpu, func, info, wait); - WARN_ON_ONCE(!ret); + WARN_ON_ONCE(ret); } preempt_enable(); } _ -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
