This is a note to let you know that I've just added the patch titled
hwmon: (lm78) Fix overflow problems seen when writing large temperature
limits
to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
hwmon-lm78-fix-overflow-problems-seen-when-writing-large-temperature-limits.patch
and it can be found in the queue-3.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From 1074d683a51f1aded3562add9ef313e75d557327 Mon Sep 17 00:00:00 2001
From: Guenter Roeck <[email protected]>
Date: Tue, 29 Jul 2014 20:48:59 -0700
Subject: hwmon: (lm78) Fix overflow problems seen when writing large
temperature limits
From: Guenter Roeck <[email protected]>
commit 1074d683a51f1aded3562add9ef313e75d557327 upstream.
On platforms with sizeof(int) < sizeof(long), writing a temperature
limit larger than MAXINT will result in unpredictable limit values
written to the chip. Avoid auto-conversion from long to int to fix
the problem.
Cc: Axel Lin <[email protected]>
Reviewed-by: Axel Lin <[email protected]>
Signed-off-by: Guenter Roeck <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
drivers/hwmon/lm78.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/hwmon/lm78.c
+++ b/drivers/hwmon/lm78.c
@@ -108,7 +108,7 @@ static inline int FAN_FROM_REG(u8 val, i
* TEMP: mC (-128C to +127C)
* REG: 1C/bit, two's complement
*/
-static inline s8 TEMP_TO_REG(int val)
+static inline s8 TEMP_TO_REG(long val)
{
int nval = clamp_val(val, -128000, 127000) ;
return nval < 0 ? (nval - 500) / 1000 : (nval + 500) / 1000;
Patches currently in stable-queue which might be from [email protected] are
queue-3.10/hwmon-sis5595-prevent-overflow-problem-when-writing-large-limits.patch
queue-3.10/hwmon-ads1015-fix-off-by-one-for-valid-channel-index-checking.patch
queue-3.10/hwmon-lm78-fix-overflow-problems-seen-when-writing-large-temperature-limits.patch
queue-3.10/hwmon-gpio-fan-prevent-overflow-problem-when-writing-large-limits.patch
queue-3.10/hwmon-ads1015-fix-out-of-bounds-array-access.patch
queue-3.10/hwmon-dme1737-prevent-overflow-problem-when-writing-large-limits.patch
queue-3.10/hwmon-lm85-fix-various-errors-on-attribute-writes.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
