The patch titled
Subject: mm/balloon_compaction: keep ballooned pages away from normal
migration path
has been removed from the -mm tree. Its filename was
mm-balloon_compaction-keep-ballooned-pages-away-from-normal-migration-path.patch
This patch was dropped because an updated version will be merged
------------------------------------------------------
From: Konstantin Khlebnikov <[email protected]>
Subject: mm/balloon_compaction: keep ballooned pages away from normal migration
path
Proper testing shows yet another problem in balloon migration: it works
only once for each page. balloon_page_movable() check page flags and
page_count. In __unmap_and_move page is locked, reference counter is
elevated, so balloon_page_movable() _always_ fails here. As result in
__unmap_and_move() migration goes to the normal migration path.
Balloon ->migratepage() is so special, it returns
MIGRATEPAGE_BALLOON_SUCCESS instead of MIGRATEPAGE_SUCCESS. After that in
move_to_new_page() successfully migrated page got NULL into its mapping
pointer and loses connectivity with balloon and ability for further
migration.
It's safe to use __is_movable_balloon_page here: page is isolated and pinned.
[[email protected]: fix CONFIG_BALLOON_COMPACTION=n build]
Signed-off-by: Konstantin Khlebnikov <[email protected]>
Acked-by: Rafael Aquini <[email protected]>
Cc: Andrey Ryabinin <[email protected]>
Cc: <[email protected]> [v3.8+]
Signed-off-by: Andrew Morton <[email protected]>
---
include/linux/balloon_compaction.h | 5 +++++
mm/migrate.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff -puN
mm/migrate.c~mm-balloon_compaction-keep-ballooned-pages-away-from-normal-migration-path
mm/migrate.c
---
a/mm/migrate.c~mm-balloon_compaction-keep-ballooned-pages-away-from-normal-migration-path
+++ a/mm/migrate.c
@@ -873,7 +873,7 @@ static int __unmap_and_move(struct page
}
}
- if (unlikely(balloon_page_movable(page))) {
+ if (unlikely(__is_movable_balloon_page(page))) {
/*
* A ballooned page does not need any special attention from
* physical to virtual reverse mapping procedures.
diff -puN
include/linux/balloon_compaction.h~mm-balloon_compaction-keep-ballooned-pages-away-from-normal-migration-path
include/linux/balloon_compaction.h
---
a/include/linux/balloon_compaction.h~mm-balloon_compaction-keep-ballooned-pages-away-from-normal-migration-path
+++ a/include/linux/balloon_compaction.h
@@ -258,6 +258,11 @@ static inline void balloon_page_delete(s
list_del(&page->lru);
}
+static inline bool __is_movable_balloon_page(struct page *page)
+{
+ return false;
+}
+
static inline bool balloon_page_movable(struct page *page)
{
return false;
_
Patches currently in -mm which might be from [email protected] are
include-linux-migrateh-remove-migratepage-define.patch
mm-balloon_compaction-isolate-balloon-pages-without-lru_lock.patch
mm-introduce-common-page-state-for-ballooned-memory.patch
mm-balloon_compaction-use-common-page-ballooning.patch
mm-balloon_compaction-general-cleanup.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
