[ 
https://issues.apache.org/jira/browse/STANBOL-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169341#comment-13169341
 ] 

Florent ANDRE commented on STANBOL-414:
---------------------------------------

Hi Reto !

Big +1 with the multipart ContentItem.

I had a read of your patch, and ask myself a question about a "link" 
(reference) between one part in the blob and the RDF metadata.

In the "addpart(UriRef uriRef, Object object)" implementation the UriRef of the 
part is not added to the RDF metadata.
So it's up to the engine that process this part to add a reference to that part 
when metadata is extracted ? 

Another point, I'm not sure to see the value added by the remove of ci.getId 
and then the remplacement of ci.getId() by ci.getUri().getUnicodeString()... 
but I'm sure there is a good reason.

About the enhancer endpoint, I created STANBOL-431 for discuss about it.
Thanks
                
> Refactor EnhancementEngine to support contents with multiple related parts
> --------------------------------------------------------------------------
>
>                 Key: STANBOL-414
>                 URL: https://issues.apache.org/jira/browse/STANBOL-414
>             Project: Stanbol
>          Issue Type: Improvement
>            Reporter: Reto Bachmann-Gmür
>         Attachments: 
> 0001-CLEREZZA-414-changed-ContentItem-interface-and-utili.patch
>
>
> Some notes from a discussion with Rupert and Olivier
> ContentItem
> - getBlob() returns a blob of type multipart/mime iff the ContentItem was 
> created from a multipart/mime content
> - ci.getBlob() eq ci.getPart(0, Blob.class)
> - ci.getUri()+"_main" eq ci.getPartUri(0)
> Rest
> /enhancer
> /enhancer/engine/<engineId>
> /enhancer/chains/<chaiId>
> - query params: 
> Optional inputWithMetadata -> expects multipart/mime with 2 sections of which 
> the first is rdf
> Optional outputWithContentParts[=<section-ordinal>] -> the result is 
> multipart (instead of rdf) containing rdf as the first section and the parts 
> in the second section, if there is more than one part this second section is 
> itself multipart, this argument might be repated to have different sections
> Optional omitMetada -> no metadate in the result, makes only sense with 
> outputContentParts argument, the result will correspond to the second section 
> of the malipart returned without this argument

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to