On Mon, Dec 13, 2010 at 11:28 AM, Stefane Fermigier <[email protected]> wrote: > On Dec 13, 2010, at 10:22 AM, Bertrand Delacretaz wrote: >>... My advice is: if you just change a few lines in an existing file, just >> follow that file's style. And above all don't mix reformatting and >> code changes in commits as I said elsewhere. > > I agree that when you are a newcomer to an existing code base, you should by > all mean refrain from reformatting the code to your own taste, if the code > base already uses a consistent convention. > > OTOH, I think it gives a very bad impression to newcomers or people that just > want to study your code (for some reason, including evaluating it for their > own use) if they find that you're using very inconsistent styles in your code > base, i.e. tabs vs spaces, 2 vs 4 indents, 1TBS > (http://en.wikipedia.org/wiki/Indent_style#Variant:_1TBS) vs. Allman, etc.
I agree that being very inconsistent would be bad...for now I suggest starting with the suggested reformatting and come back to this if we see problems. -Bertrand
