Hi Rupert, On Sat, Apr 16, 2011 at 8:06 PM, Rupert Westenthaler <[email protected]> wrote: > On Fri, Apr 15, 2011 at 2:16 PM, Bertrand Delacretaz > <[email protected]> wrote: >> Maybe later...the simplest might be be an additional return value for >> canEnhance(...): the reason why that method returns no, "system is >> offline" in this case, or a specific return value. > > In my opinion canEnhance(...) can not be used, because the state can > change between the calls to canEnhance(...) and > computeEnhancements(...) - especially if the Enhancements are > calculated. > This is also the reason, why I do not check for offlineMode in > canEnhance(...).
Ok, makes sense. > > However we could use an Integer that indicates the state as return > value to computeEnhancements(...). > > An other possibility would be that Engines add informations about the > states to the Enhancement Results. I'd prefer the former option: a return value that indicates what happened. > Based on the feedback I will mark STANBOL-162 as resloved Ok, thanks for taking care of this. -Bertrand
