Hello everyone, since my merge requests at https://gitorious.org/xmpp/xmpp/merge_requests got unnoticed, I was told to use the standards ML instead.
As my mail relay is currently broken I can't use "git send-mail", so please excuse me simply adding the patches inline. Regarding #2 roominfo_pubsub is shown in Example 10, but not specified in 15.5.4. I'm not sure if this is just missing or meant as example that there could be more fields besides the specified ones. The problem is that pubsub is defined with the roomconfig prefix in 15.5.3. The ideal solution IMHO would be do drop the prefixes and just got with 'muc#pubsub' in 15.5.3 and 15.5.4, like it has been done with maxhistoryfetch. Not sure if this is still doable (e.g. if there are implementations out there that use already this field). Best Florian >From 3a72bfa9897fd29a3668498d844315a1ccae08c2 Mon Sep 17 00:00:00 2001 From: Florian Schmaus <[email protected]> Date: Sun, 24 Aug 2014 21:34:03 +0200 Subject: [PATCH 1/2] XEP-0045: Remove duplicate 'changesubject' field in Example 10 --- extensions/xep-0045.xml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/extensions/xep-0045.xml b/extensions/xep-0045.xml index d8d90bc..9d6da71 100644 --- a/extensions/xep-0045.xml +++ b/extensions/xep-0045.xml @@ -1162,10 +1162,6 @@ label='Current Discussion Topic'> <value>Spells</value> </field> - <field var='muc#roomconfig_changesubject' - label='Subject can be modified'> - <value>true</value> - </field> <field var='muc#roominfo_occupants' label='Number of occupants'> <value>3</value> -- 1.9.3 >From 91266a32c2bb405a442bebcf373b6d7cbe2cf379 Mon Sep 17 00:00:00 2001 From: Florian Schmaus <[email protected]> Date: Sun, 24 Aug 2014 23:02:28 +0200 Subject: [PATCH 2/2] XEP-0045: Add 'muc#roominfo_pubsub' to 15.5.4 --- extensions/xep-0045.xml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/extensions/xep-0045.xml b/extensions/xep-0045.xml index 9d6da71..47c0347 100644 --- a/extensions/xep-0045.xml +++ b/extensions/xep-0045.xml @@ -5181,6 +5181,10 @@ deployment-specific definition of a group.'/> <field + var='muc#roominfo_pubsub' + type='text-single' + label='XMPP URI of Associated Publish-Subcribe Node'/> + <field var='muc#roominfo_logs' type='text-single' label='URL for Archived Discussion Logs'/> -- 1.9.3
