Jonasm

> -----Original Message-----
> From: Standards [mailto:[email protected]] On Behalf Of Jonas
> Wielicki
> Sent: 02 March 2017 21:03
> To: XMPP Standards
> Subject: [Standards] XEP-0369: xmlns in disco#info feature elements
> 
> 
> <iq type='result'
>     to='[email protected]/d104f6a7-97e9-477f-8947-
> e4a37691d7ee/
> 7533375f-2cd1-4455-a311-494bab21f9f0'
>     from='mix.shakespeare.example'
>     id='7nve413p'>
>     <query xmlns='http://jabber.org/protocol/disco#info'/>
>         <feature xmlns='urn:xmpp:mix:0' var='mix_nick_register'/>
>     </query>
> </iq>
> 
> The use of a different namespace on <feature/> in a disco#info reply worries
> me. This doesn’t work with XEP-0115 (I hope, because
> <{urn:xmpp:mix:0}feature/
> > and <{http://jabber.org/protocol/disco#info}feature/> are
> > fundamentally
> different elements) and is, as far as I know, specified nowhere as a valid use
> of disco#info. Of course, disco#info permits additional elements as
> extension, but I don’t know whether that was intended here.
> 
> I think the cleaner way would be to use
> var='urn:xmpp:mix:0#mix_nick_register'
> like like many other XEPs do. That way other protocols relying on all features
> being available in {http://jabber.org/protocol/disco#info}feature elements
> won’t break.
> 
> I feel this hasn’t got enough discussion yet, which is why I’m bringing it up
> once more in a separate thread.

[Steve Kille] 

Thanks for pointing this out in your original message and again here and for 
suggesting the correct fix.

Please be patient with me.   I had not forgotten this.

I have fixed this for 0.8.2 and also two other occurrences of the same issue

Please keep the review comments coming!



Steve


_______________________________________________
Standards mailing list
Info: https://mail.jabber.org/mailman/listinfo/standards
Unsubscribe: [email protected]
_______________________________________________

Reply via email to