On 15/12/2021 17.33, Dave Cridland wrote:


On Wed, 15 Dec 2021 at 16:14, Florian Schmaus <[email protected] <mailto:[email protected]>> wrote:

    On 15/12/2021 15.41, Dave Cridland wrote:
     > For the benefit of others wanting context, this is XEP-0060 section
     > 8.2.4. The existing SHOULD in this section is probably wrong, in
    as much
     > as it's either meaningless (to configure a node, obviously you
    send the
     > form) or else egregious (if you pull the form and the node seems
    to be
     > set right, why reconfigure it?).

    +1

     > On Wed, 15 Dec 2021 at 04:38, Travis Burtrum <[email protected]
    <mailto:[email protected]>
     > <mailto:[email protected] <mailto:[email protected]>>> wrote:
     >
     >       > The submitted configuration form MAY contain a subset of
    possible
     >     configuration options. In that case, the service MUST only
    change the
     >     submitted configuration options.
     >
     >
     > I don't think that text expresses what is actually intended. I think
     > what you want to say is that if a client doesn't provide all the
     > options, the server fills in the "missing" values from the
    configuration
     > form defaults, and not global defaults or something.

    No, I think this is not why the motivation and intention behind the
    proposed change is. "Filling unspecified values with the configuration
    form defaults" does not sound sensible, assuming that it means
    unspecified values could potentially be reset to their initial default
    values if they have been modified afterwards.


By "the configuration form defaults", I mean the defaults in the configuration form from 8.2.2, which "SHOULD" be the current node configuration values, and not any kind of global defaults.

So I think you're agreeing with me, aren't you?

Seems so! \o/ Although this might indicate that "defaults from the configuration" can be misleading. I believe "current configuration values" is clearer.

With that, we could potentially improve as follows:

---
Incomplete Submission Form Handling

Incomplete submission forms are forms of the type 'submit, where are all required fields are set, but some non-required fields are omitted. The receiving entity of an incomplete submission form SHOULD only process (e.g., apply) the submitted fields. If applicable, the values of the omitted fields keep their current value (often the "default" value found in the corresponding 'form' type form).
---

How is that?

- Florian

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
Standards mailing list
Info: https://mail.jabber.org/mailman/listinfo/standards
Unsubscribe: [email protected]
_______________________________________________

Reply via email to