On Thu, Jan 27, 2005 at 07:20:01PM +0000, Pablo Nicolás Nuñez Pölcher wrote: > Hi everybody,
hi pablo, > > - useless comments: nothing against you pablo, but things like > > //!set gamma > > void set_gamma(float g); > > are useless (I know, I also do it) > > It's okay. :) Should we use as a general rule, then, that > self-explanatory method > names shouldn't have any comments regarding their use? (Except, of course, > that it's necessary to explain something apart from the use). yes, we should do something like that > I also say that we should maybe have helper classes for image loading (for > example, to remove se::image_load(...)) and keep the se class just for > functions > that belong exclusively to the game. That'll help us keep the code reusable > and > easier to modify. that was planned already this methods are going to be removed once the transition to GL is completed > BTW, I'm rewriting the FLC decoder. Would you find it better if I > wrote the video > support right into the decoder, or should I keep the game->display logic to > show > the frames on screen? the game->display is NOT the right way to do that currently you have to declare an image_container containing the video and bind it to the intro screen you can modify directly the SDL_Surface* inside the container and each time you need to update the screen put the variable game->screen2update to true. right now the flc decoder has an ugly hack inside it which should clearly be removed : creating an 8bpp screen that's it. I hope the new display system is clearer now Fred -- Why fear computers ? They don't byte !
