Oops, hit "Reply" instead of "Reply All". ---------- Forwarded message ---------- From: Jeffery To <jeffery...@gmail.com> Date: Sun, Oct 11, 2009 at 2:21 AM Subject: Re: [StatusNet-dev] Template Plugin To: Evan Prodromou <e...@status.net>
On Sat, Oct 10, 2009 at 2:24 AM, Evan Prodromou <e...@status.net> wrote: > Well, I think the main issue is whether the template plugin we have is > really how we want to do templating (I don't think it is). As it stands > right now, if you are using template plugin, You're Doing It Wrong. If using the template plugin is Wrong, then that plugin shouldn't be part of the official distribution, or there should be very strong messaging (in the README or in the plugin source) that says Do Not Use This. > > 1) Change Event::handle() to call all registered handlers, instead of > > stopping after the first false return value. > > No way. We absolutely want to let plugins replace or prevent the default > behaviour at event times, not just augment it. I'm not suggesting that plugins can't prevent default behaviour, but that all event handlers should have the chance to run. If one or more returns false, then prevent the default behaviour. > > 2) Change all event triggering code to always trigger the end event, > > i.e. move it out of the if block. > > That doesn't match the semantics of what those events are for. Consider the > EndNoticeSave event, which fires when we've correctly saved a notice. It > would be incorrect to fire that event if a plugin has blocked the save. There's a difference between "the action has ended" and "the action was successful". Maybe I'm the only one that sees having both as being useful. Jeff _______________________________________________ StatusNet-dev mailing list StatusNet-dev@lists.status.net http://lists.status.net/mailman/listinfo/statusnet-dev
