Farid Zaripov wrote:
[...]
------------------------------------------------------------------------
Index: 21.strings.cpp
===================================================================
--- 21.strings.cpp (revision 425643)
+++ 21.strings.cpp (working copy)
@@ -153,7 +153,7 @@
[...]
@@ -414,9 +416,9 @@
// FUNCALL: a string describing the call to the basic_string function
// with function with function arguments expanded (as specified
// by the TestCase argument)
-static void
-_rw_setvars (const StringFunc &func,
- const StringTestCase *pcase = 0)
+void
+rw_setvars (const StringFunc &func,
+ const StringTestCase *pcase = 0)
Test driver functions declared extern need to be also decorated with
the _TEXT_EXPORT macro. We should also declare the rw_setvars() in
the header (rather than in the tests that use it. The declaration
(but not the definition) should specify the default argument.
Martin
PS When posting a patch to the list (either to be applied or for
review before committing it) it's helpful to label the email with
[PATCH] first in the subject line.
PPS Please don't forget to use the new license text -- you can
copy it, for example, from here:
http://svn.apache.org/repos/asf/incubator/stdcxx/trunk/tests/strings/21.string.append.cpp
PPPS I decided to make the changes and commit the driver part of
your patch here: http://svn.apache.org/viewvc?rev=426298&view=rev
so treat my comments as an FYI for the future :)
