Greetings Farid
The revised patch looks good to me and probably can be committed.
Unfortunately, I am uncertain what the protocol is on committing such
patches, as Martin is out of the office for a couple days. I suppose
the worst case scenario is that it waits until some time next week to be
committed after he has caught up.
--Andrew Black
Farid Zaripov wrote:
> -----Original Message-----
> From: Andrew Black [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, August 23, 2006 12:02 AM
> To: [email protected]
> Subject: Re: [PATCH] exec utility patch
>
> The first observation I have is that there is a certain
> amount of 'noise' in the patch from spelling corrections in
> comments. These spelling fixes should probably be submitted
> as a separate cleanup patch.
That is VisualAssist plugin for VisualStudio underlines with red
color the incorrect words and I corrected that words to not see them.
I have disabled spelling feature for now.
>
> The second observation I have is about the use of get_signame
> on the SIGSEGV constant. It would be more efficient to use
> 'puts (" SEGV\n")
> ;' rather than calling printf on a function that returns
> what is essentially a constant. An additional benefit is
> that you wouldn't need to include signal.h.
Agreed. Corrected patch is attached.
Farid.
