Andrew Black wrote:
Take two on the patches are attached (removing most of the whitespace
changes).
I've done a little more cleanup on the patterns (including removing the
unneeded escapes within the [] blocks), and I think the pattern is about
as simple as I can get it. It would be possible to remove some of the
capture braces, but I decided against this, as it would remove some of
the similarities between the pairs of patterns that can provide a
measure of context to other developers working on the code.
I'm not certain if standardization would be the most accurate
description of what I did, but it is accurate enough. The (basically)
same pair of patterns was used in 3 different locations, and I replaced
all these instances with a single pair of patterns.
I see. So by standardization you mean making semantically equivalent
expressions syntactically identical, and not avoiding non-standard
(as in non-portable) constructs.
I clarified your changelog to that effect and committed both patches
here: http://svn.apache.org/viewvc?rev=439399&view=rev.
Thanks
Martin
