Farid Zaripov wrote:
-----Original Message-----
From: Martin Sebor [mailto:[EMAIL PROTECTED]
Sent: Monday, October 02, 2006 6:00 PM
To: [email protected]
Subject: Re: [PATCH] Scripts, generating solution and
projects for MSVC/ICC [2]
Should we replace #ifdef _RWBUILD_std to #ifdef _RWSTD_LIB_SRC in
_defs.h?
Yes. It should also key in on _RWSHARED.
_RWSHARED is present in outer #ifdef:
---------------------
#if (defined (_WIN32) || defined (_WIN64)) && \
(defined (RWDLL) || defined (_RWSHARED))
Commited here: http://svn.apache.org/viewvc?view=rev&revision=452509
Okay. FYI, the _WIN32 || _WIN64 conditional above (and in the
rest of our code) can be simplified to just _WIN32 since the
macro is guaranteed to be #defined when _WIN64 is #defined.
CXX, LD, AR variables are used at configure step only.
And not when bulding the lib? Why not?
Because we use MS VisualStudio development envorinment (devenv.exe)
in build process. Devenv itself selects what tool should be invoked to
compile
the partucular source file (i.e. cl.exe for .c, .cpp files; rc for .rc
files). We
cannot change this behavior.
Gotcha! It would be good to mention this in comments for each
of these variables.
Martin
