Farid Zaripov wrote:
-----Original Message-----
From: Martin Sebor [mailto:[EMAIL PROTECTED]
Sent: Monday, June 04, 2007 9:36 PM
To: [email protected]
Subject: Re: [PING] Re: svn commit: r541672 -
/incubator/stdcxx/trunk/include/rw/_config-msvc.h
What I see, is that we could remove all section between
#if _MSC_VER <= 1200 // MSVC <= 6.0
and
#endif // MSVC <= 6.0
because of the all macros are defined in config.h at the
configure
step.
I think the reason why they are defined in _config_msvc.h is
because the autoconfigured ones are (or were at some point)
incorrectly detected. That certainly may have changed so we
need to check to make sure they are now detected correctly
before we take out the overriding definitions.
I was not carefully read the comments. Since that section is related
to
the MSVC 6.0 and earlier, I can't check whether that macros detected
correctly or not.
Okay, I assume that doesn't change our decision to add the new
config header (_config-msvcrt.h), correct? You can just move
all these conditionally #defined macros there for now. At some
point in the future we'll clean up all the MSVC 6.0 cruft since
I don't think we'll ever go back and try to support it.
Martin
