I realized that we never closed this vote. Re-reading the thread
in the archive pretty much everyone was in favor of what's being
referred to as option (3) below with no objections to the
enhancement to add more detail after the section number so the
convention to follow is as follows:

  <section-number>.<dot-clause>.stdcxx-<issue-number>.cpp

with the dot-clause being optional if the test doesn't correspond
to a single specific clause.

For the record, the vote thread starts here:
http://www.mail-archive.com/[email protected]/msg02920.html

Martin

Martin Sebor wrote:
I also like option (3) best, so sounds like the home for
the new regression tests is unanimously in tests/regress/

The remaining question is the file name convention. Do we
go with <section-number>.stdcxx-<issue-number>.cpp or do
we allow things like:

<section-number>.<dot-clause>.stdcxx-<issue-number>.cpp

e.g., 23.vector.cons.stdcxx-123.cpp

FWIW, I see no reason not to allow it since it provides
additional useful detail.

Martin

Mark Brown wrote:
-----Original Message-----
From: [EMAIL PROTECTED]
Sent: Wed, 21 Mar 2007 09:56:30 -0600
To: [email protected]
Subject: Re: [VOTE] Re: regression test suite naming convention

If we constrain ourselves to the proposed options, my vote is for Option
2.  The reason for this vote is because it allows us to more easily
determine what regression tests need to be run for a particular change.

If we don't constrain ourselves to the proposed options, I wish to put
forward an additional option.

Option 3:
    Put all regression tests in tests/regress/, using the following
    naming convention:
    tests/regress/<section-number>.stdcxx-<issue-number>.cpp

This option would allow us to quickly locate all regression tests, and
identify which section each regression test applies to without
consulting Jira.

I also think this option is better than the one I suggested. I suppose the file name could include even more specific detail than just the section number such as the name of the container or the member function, like vector.cons and so on.

-- Mark



--Andrew Black

Martin Sebor wrote:
I'm not hearing any yay's or nay's on the proposed convention
so how about a vote to practice our consensus building skills?
Everyone is encouraged to vote, including non-committers.

Option 1:
  Put all regression tests in tests/regress/, naming each as
  follows:
  tests/regress/stdcxx-<issue-number>.cpp

Option 2:
  Mix regression tests in with the rest based on the clause
  in the standard and name each according to the following
  formula:
  tests/<section>/<section-number>.stdcxx-<issue-number>.cpp

Martin


Reply via email to