> -----Original Message----- > From: Martin Sebor [mailto:[EMAIL PROTECTED] > Sent: Friday, June 08, 2007 7:51 PM > To: [email protected] > Subject: Re: svn commit: r545533 - > /incubator/stdcxx/trunk/include/sstream >
[...] > first_ and last_ are not reserved names -- names of local > variables in library headers (including .cc files) must be in > the private namespace reserved to the implementation, such > as, __first and __last. You might want to add the names > first_ and last_ to the 17.names.cpp test to help us catch > this mistake in the future (and I really need to fix valarray > so that the test compiles!) > > Also, since the function has grown quite a bit it needs to be > moved outside of the enclosing template. It looks small > enough that it can stay inline (i.e., still defined in the header). Done: http://svn.apache.org/viewvc?view=rev&rev=546535 Farid.
